Open
Conversation
connortsui20
force-pushed
the
ct/ext-vec
branch
from
b94c506 to
33409b3
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/ext-vec
branch
from
33409b3 to
5a198e8
Compare
13 tasks
gatesn
reviewed
Mar 16, 2026
| Ok(args.to_vec()) | ||
| } | ||
|
|
||
| // TODO(connor): This needs a precondition for the number of args it has, or all implementations |
Contributor
There was a problem hiding this comment.
There should already be a check using the arity of the function
Contributor
Author
There was a problem hiding this comment.
I tried backtracing through the code myself but I couldn't find where that is called
gatesn
reviewed
Mar 16, 2026
gatesn
reviewed
Mar 16, 2026
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking Issue: #6865
Adds a
Vectorextension type and a newL2Normexpression.Additionally adds a
AnyTensortype that can be matched on for any kind of tensor we want.Right now the code assumes that everything is built on top of
FixedSizeList, but in the future that might change.Additionally make some touchups to the
vortex-tensorcrate in general.API Changes
The new
VectorandL2Normtypes.Testing
Some basic tests.